[FFmpeg-devel] [PATCH]libavformat/http: fix http error eof

[Ronald S. Bultje]

Hi,

On Thu, Jun 1, 2017 at 5:55 PM, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Thu, Jun 01, 2017 at 07:48:38AM -0400, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Thu, Jun 1, 2017 at 2:27 AM, raymond zheng <
> raymondzheng1412 at gmail.com>
> > wrote:
> >
> > > This patch is only for solving the bug introduced by chunksize has been
> > > initial set as UINT64 MAX.
> > >
> >
> > I understand. So what will happen if the server responds that the
> chunksize
> > is really actually UINT64_MAX? How do we distinguish between that and
> > chunksize being unset (which is what UINT64_MAX currently means)? We'll
> > need a flag to indicate whether chunksize is specified by the server or
> > not, right?
>
> does UINT64_MAX chunksize make sense ?
> doesnt this indicate that theres a really huge chunk ?
> or does it have some special meaning ?
> iam asking because this feels a bit odd. Could a server use
> UINT64_MAX + 1 instead of UINT64_MAX ? If so the point of failure moves
> by one in UINT64_MAX by adding a flag, or maybe i misunderstand


Fair enough, patch is OK then.

Ronald