[FFmpeg-devel] [PATCH 09/11] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

[Michael Niedermayer]

On Tue, Jun 20, 2017 at 07:56:40AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jun 19, 2017 at 11:11 AM, James Darnley <jdarnley at obe.tv> wrote:
> 
> > Created by Ronald S. Bultje
> > ---
> >  libavcodec/x86/simple_idct10_template.asm | 38
> > +++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/libavcodec/x86/simple_idct10_template.asm
> > b/libavcodec/x86/simple_idct10_template.asm
> > index d8ea0bcc6b..51baf84c82 100644
> > --- a/libavcodec/x86/simple_idct10_template.asm
> > +++ b/libavcodec/x86/simple_idct10_template.asm
> > @@ -257,6 +257,44 @@
> >      pmullw      m12,[%8+96]
> >
> >      IDCT_1D     %1, %2, %8
> > +%elif %2 == 11
> > +    por     m1, m8, m13
> > +    por     m1, m12
> > +    por     m1, [blockq+ 16]       ; { row[1] }[0-7]
> > +    por     m1, [blockq+ 48]       ; { row[3] }[0-7]
> > +    por     m1, [blockq+ 80]       ; { row[5] }[0-7]
> > +    por     m1, [blockq+112]       ; { row[7] }[0-7]
> > +    pxor    m2, m2
> > +    pcmpeqw m1, m2
> > +    psllw   m2, m10, 3
> > +    pand    m2, m1
> > +    pcmpeqb m3, m3
> > +    pxor    m1, m3
> > +    mova    [rsp], m1
> > +    mova    [rsp+16], m2
> > +
> > +    IDCT_1D     %1, %2
> > +
> > +    mova m5, [rsp]
> > +    mova m6, [rsp+16]
> > +    pand m8, m5
> > +    por  m8, m6
> > +    pand m0, m5
> > +    por  m0, m6
> > +    pand m1, m5
> > +    por  m1, m6
> > +    pand m2, m5
> > +    por  m2, m6
> > +    pand m4, m5
> > +    por  m4, m6
> > +    pand m11, m5
> > +    por  m11, m6
> > +    pand m9, m5
> > +    por  m9, m6
> > +    pand m10, m5
> > +    por  m10, m6
> > +    pand m3, m5
> > +    por  m3, m6
> >  %else
> 
> 
> Can you fix the indentation while you push it? LGTM.

as ive been asked abouz 9/10/11, no objections from me


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170624/92d5c306/attachment.sig>