[FFmpeg-devel] [PATCH 1/2] avfilter/proresenc: switch default prores encoder to prores_ks

[Michael Niedermayer]

On Mon, Jun 26, 2017 at 04:09:57PM +0200, Paul B Mahol wrote:
> Rationale:
> prores_ks have more features and is faster for qscale > 0
> and gives better quality output.
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavcodec/Makefile             |  2 +-
>  libavcodec/proresenc_anatoliy.c | 14 --------------
>  libavcodec/proresenc_kostya.c   | 17 +++++++++++++++++
>  3 files changed, 18 insertions(+), 15 deletions(-)

after fixing priv_class, this breaks fate

--- ./tests/ref/vsynth/vsynth1-prores   2017-06-25 12:50:38.707315869 +0200
+++ tests/data/fate/vsynth1-prores      2017-06-26 23:25:49.523287109 +0200
@@ -1,4 +1,4 @@
-7ca7d2f9f5d8ac2ead691b1b6a70d409 *tests/data/fate/vsynth1-prores.mov
-5022821 tests/data/fate/vsynth1-prores.mov
-fb4a9e025d12afc0dbbca8d82831858f *tests/data/fate/vsynth1-prores.out.rawvideo
-stddev:    2.47 PSNR: 40.27 MAXDIFF:   31 bytes:  7603200/  7603200
+339c606584cff069fb02b0a3195e15db *tests/data/fate/vsynth1-prores.mov
+3858911 tests/data/fate/vsynth1-prores.mov
+100eb002413fe7a632d440dfbdf7e3ff *tests/data/fate/vsynth1-prores.out.rawvideo
+stddev:    3.17 PSNR: 38.09 MAXDIFF:   39 bytes:  7603200/  7603200
Test vsynth1-prores failed. Look at tests/data/fate/vsynth1-prores.err for details.
make: *** [fate-vsynth1-prores] Error 1

it also reduces the quality of encoding this case

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170626/b03ee100/attachment.sig>