[FFmpeg-devel] [PATCH]lavf/flacdec: Return maximum score if a valid streaminfo header was found

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Mar 2 10:34:23 EET 2017


2017-03-02 3:09 GMT+01:00 Michael Niedermayer <michael at niedermayer.cc>:
> On Wed, Mar 01, 2017 at 09:38:58AM +0100, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> I implemented this patch to fix ticket #6208 but it turned out the flac probe
>> function wasn't the issue. Still looks like a good idea to me.
>>
>> Please comment, Carl Eugen
>
>>  flacdec.c |    9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>> 64259ee8c398e244db4174257a3f1bbad6160ca7  0001-lavf-flacdec-Return-maximum-score-if-the-streaminfo-.patch
>> From acc7558a3585d99776523ed670747597c4de99fb Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
>> Date: Wed, 1 Mar 2017 09:34:37 +0100
>> Subject: [PATCH 1/2] lavf/flacdec: Return maximum score if the streaminfo
>>  header is valid.
>>
>> ---
>>  libavformat/flacdec.c |    9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> if this works with all flac files you have then its probably ok
> but i wouldnt be surprised if some of this will need to be tuned
> based on future tickets

Committed a variant that does not change behaviour for files
with an invalid streaminfo header (and better matches the commit
message).

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list