[FFmpeg-devel] [PATCH]lavc/avpacket: Make pkt parameter of av_packet_get_side_data() const

[Carl Eugen Hoyos]

2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> 2017-02-26 11:51 GMT+01:00 Nicolas George <george at nsup.org>:

>>> -uint8_t* av_packet_get_side_data(AVPacket *pkt, enum AVPacketSideDataType type,
>>
>>> +uint8_t* av_packet_get_side_data(
>>> +#if FF_API_CONST_GET_SIDE_DATA
>>> +const
>>> +#endif
>>> +                                 AVPacket *pkt, enum AVPacketSideDataType type,
>>
>> I do not think we need the FF_API dance, since it is not an ABI break.
>
> I agree that there is no ABI break (but I suspect FF_API does not
> imply an ABI break).
>
>> I think is is not an API break either.
>
> I may misremember but I thought it's an API break for c++ users.
>
> Anyway, new patch attached.

Ping.
Should this not be changed, should one of the patches be applied?

Thank you, Carl Eugen