[FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

[James Almer]

On 2/28/2017 1:24 PM, Vittorio Giovara wrote:
> On Tue, Feb 28, 2017 at 10:58 AM, James Almer <jamrial at gmail.com> wrote:
>> On 2/21/2017 8:07 PM, James Almer wrote:
>>> On 2/21/2017 7:35 PM, Vittorio Giovara wrote:
>>>> Update the fate test as needed.
>>>> ---
>>>>  libavformat/mov.c                 | 28 +++++++++++++++++++++++++++-
>>>>  tests/ref/fate/mov-spherical-mono |  6 +++++-
>>>>  2 files changed, 32 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/libavformat/mov.c b/libavformat/mov.c
>>>> index 7b0bbcc..d798336 100644
>>>> --- a/libavformat/mov.c
>>>> +++ b/libavformat/mov.c
>>>> @@ -4637,6 +4637,8 @@ static int mov_read_sv3d(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>>>>      MOVStreamContext *sc;
>>>>      int size, version;
>>>>      int32_t yaw, pitch, roll;
>>>> +    size_t l, t, r, b;
>>>> +    size_t padding = 0;
>>>>      uint32_t tag;
>>>>      enum AVSphericalProjection projection;
>>>>
>>>> @@ -4716,9 +4718,25 @@ static int mov_read_sv3d(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>>>>      switch (tag) {
>>>>      case MKTAG('c','b','m','p'):
>>>>          projection = AV_SPHERICAL_CUBEMAP;
>>>> +        padding = avio_rb32(pb);
>>>
>>> Doesn't layout come first?
> 
> Ah, that's right, thanks

You pushed this patch without fixing it...