[FFmpeg-devel] [PATCH 2/3] avformat: reject FFmpeg-style merged side data in raw packets

[Michael Niedermayer]

On Wed, Mar 08, 2017 at 07:32:26PM +0100, wm4 wrote:
> On Wed, 8 Mar 2017 19:20:15 +0100
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > On Wed, Mar 08, 2017 at 05:26:57PM +0100, wm4 wrote:
> > > On Wed, 8 Mar 2017 17:11:12 +0100
> > > Michael Niedermayer <michael at niedermayer.cc> wrote:
> > >   
> > > > On Wed, Mar 08, 2017 at 04:06:20PM +0100, wm4 wrote:  
> > > > > On Wed, 8 Mar 2017 15:36:25 +0100
> > > > > Michael Niedermayer <michael at niedermayer.cc> wrote:
> > > > >     
> > > > > > On Wed, Mar 08, 2017 at 01:40:11PM +0100, wm4 wrote:    
> > [...]
> > > >  
> > > > >     
> > > > > > also it may be interresting to disable this check for fuzzing so
> > > > > > side data can be fuzzed in a wider range of cases and any past
> > > > > > testcases that happen to use this can still be used for regression
> > > > > > testing    
> > > > > 
> > > > > I think what you want is fault injection for memory errors, seems out
> > > > > of scope here.    
> > > > 
> > > > no, i want fuzzing to continue to fuzz side data, it did so in the
> > > > past and it should continue to do so.  
> > > 
> > > You can fuzz side data as much as you can fuzz AVFrame or
> > > AVCodecContext. I believe randomly changing in-memory data structures
> > > is referred to as fault injection, not fuzzing.  
> > 
> > it doesnt really matter what you call it, but it was done and the
> > patch breaks it if theres no option to disable it or something else
> 
> Well, you can't do it anymore. Why are you so afraid that a potential
> error source is being eliminated?

well its rather hidden, harder to test for not eliminated.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170308/ab35c61a/attachment.sig>