[FFmpeg-devel] [PATCH] swresample/resample: do not allow odd filter_length

[Michael Niedermayer]

On Thu, Mar 09, 2017 at 02:16:10AM +0700, Muhammad Faiz wrote:
> On Thu, Mar 9, 2017 at 1:32 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Wed, Mar 08, 2017 at 10:25:42PM +0700, Muhammad Faiz wrote:
> >> except filter_length == 1
> >>
> >> odd filter_length gives worse frequency response,
> >> even when compared with shorter filter_length
> >>
> >> also makes build_filter simpler
> >>
> >> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
> >> ---
> >>  libswresample/resample.c     | 56 +++++++++++---------------------
> >>  tests/fate/libswresample.mak | 76 ++++++++++++++++++++++----------------------
> >>  2 files changed, 56 insertions(+), 76 deletions(-)
> >
> > why does this change the checksums ?
> >
> > did they use odd filter lengths ?
> 
> Of course, filter_length is not necessarily equal with filter_size.
> for example 8000 -> 2626, filter_length = ceil(32/0.97*8000/2626) = 101

right
favoring even is of course ok

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170309/d635c624/attachment.sig>