[FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

[Michael Bradshaw]

On Wed, Mar 8, 2017 at 5:19 AM, Aaron Boxer <boxerab at gmail.com> wrote:

> Final version of simple patch to :
>
> limit encoder to single layer
> add lossless option
> set better defaults for a few encoding parameters.


I think I'd prefer to remove the numlayers option altogether if the only
possible value it can have is 1.

Small nitpick: please amend the commit message so the first line of the
message is a short summary of the overall commit, and move the numbered
list to below the first line. That is, the command git log --pretty=short
should look something like:

commit 440b7cb6abb32e35464c7c86634d655ccb1d7e7c
Author: Aaron Boxer <boxerab at gmail.com>

    <some concise summary here on a single line>

The command git log can give the full commit message:

commit 440b7cb6abb32e35464c7c86634d655ccb1d7e7c
Author: Aaron Boxer <boxerab at gmail.com>

    <some concise summary here on a single line>

    1. limit...
    2. encoder...
    3. remove...
    4. add...
    5. set...