[FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

[Moritz Barsnick]

On Sat, Mar 11, 2017 at 03:36:46 +0530, Sanchit Sinha wrote:
> Subject: [PATCH] Changes to af_ambisonic, Makefile, allfilters.c and
> Changelog

This is not a proper commit message.

> ---
>  Changelog                  | 1591
> ++++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/Makefile       |  375 +++++++++++
>  libavfilter/af_ambisonic.c |  137 ++++
>  libavfilter/allfilters.c   |  383 +++++++++++
>  4 files changed, 2486 insertions(+)
>  create mode 100644 Changelog
>  create mode 100644 libavfilter/Makefile
>  create mode 100644 libavfilter/af_ambisonic.c
>  create mode 100644 libavfilter/allfilters.c

How did you manage to make these seem like new files? Your patch is
supposed to contain the *changes* you made. Only
libavfilter/af_ambisonic.c would be added. The others are existing
files. How did you manage to create this patch?

The development process is approximately (excuse imprecisions):

git clone ...
cd ...
add your file
modify the other files
git add <your file> <the modified files>
git commit
  ... write a proper commit message - see other commits for inspiration
git format-patch ...
git send-email ...

(Don't forget to check that a complete compile works with your
modifications. And that the resulting binary does the right stuff.)

The last step will especially avoid what we are seeing here in your
e-mails, that your e-mail user agent is breaking the patches by
inserting newlines.


> +AVFILTER_DEFINE_CLASS(ambisonic);
> +static int query_formats(AVFilterContext *ctx)
> +{
> + AVFilterFormats *formats = NULL;
> + AVFilterChannelLayouts *layout = NULL;
> + int ret;
> + if ((ret = ff_add_format     (&formats, AV_SAMPLE_FMT_FLTP   )) < 0 ||
> + (ret = ff_set_common_formats     (ctx    , formats )) < 0 ||
> + (ret = ff_add_channel_layout     (&layout , AV_CH_LAYOUT_4POINT0)) < 0 ||
> + (ret = ff_set_common_channel_layouts (ctx    , layout   )) < 0)
> + return ret;
> + formats = ff_all_samplerates();
> + return ff_set_common_samplerates(ctx, formats);
> +}

Your indentation is all wrong. What happened?
http://ffmpeg.org/developer.html#Code-formatting-conventions

> +};
> \ No newline at end of file

Paul asked you to fix this (and other stuff).

Moritz