[FFmpeg-devel] [PATCH] Added AVX2 implementation for VP8 decoder (ff_pred16x16_tm_vp8_8_avx2)

[Michael Niedermayer]

On Sun, Mar 12, 2017 at 12:17:34AM -0300, James Almer wrote:
> On 3/12/2017 12:13 AM, Michael Niedermayer wrote:
> > On Sun, Mar 12, 2017 at 12:35:01AM +0530, Mirage Abeysekara wrote:
> >> ---
> >>  libavcodec/x86/h264_intrapred.asm    | 35 +++++++++++++++++++++++++++++++++++
> >>  libavcodec/x86/h264_intrapred_init.c |  7 +++++++
> >>  2 files changed, 42 insertions(+)
> >>
> > 
> > breaks build with nasm
> > 
> > src/libavcodec/x86/h264_intrapred.asm:275: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:281: error: symbol `vpbroadcastb' redefined
> > src/libavcodec/x86/h264_intrapred.asm:281: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:282: error: symbol `vpbroadcastb' redefined
> > src/libavcodec/x86/h264_intrapred.asm:282: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:283: error: symbol `vpbroadcastb' redefined
> > src/libavcodec/x86/h264_intrapred.asm:283: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:284: error: symbol `vpbroadcastb' redefined
> > src/libavcodec/x86/h264_intrapred.asm:284: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:295: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:296: error: symbol `vpermq' redefined
> > src/libavcodec/x86/h264_intrapred.asm:296: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:298: error: parser: instruction expected
> > src/libavcodec/x86/h264_intrapred.asm:300: error: symbol `vextracti128' redefined
> > src/libavcodec/x86/h264_intrapred.asm:300: error: parser: instruction expected
> 
> What version? I suppose it's an old one not supporting AVX2.
> It should be a matter of adding a HAVE_AVX2_EXTERNAL preprocessor
> guard to the asm function.

version is:
NASM version 2.09.10 compiled on Oct 17 2011

so yes, not very new

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170312/773a2645/attachment.sig>