[FFmpeg-devel] [PATCH] lavf/mpegtsenc: clarify pcr_period unit of measurement

[Michael Niedermayer]

On Wed, Mar 15, 2017 at 06:47:31PM -0800, Lou Logan wrote:
> pcr_period is in milliseconds.
> 
> Signed-off-by: Lou Logan <lou at lrcd.com>
> ---
>  libavformat/mpegtsenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
> index 0f394c5fe0..3250dde311 100644
> --- a/libavformat/mpegtsenc.c
> +++ b/libavformat/mpegtsenc.c
> @@ -1945,7 +1945,7 @@ static const AVOption options[] = {
>      { "omit_video_pes_length", "Omit the PES packet length for video packets",
>        offsetof(MpegTSWrite, omit_video_pes_length), AV_OPT_TYPE_BOOL,
>        { .i64 = 1 }, 0, 1, AV_OPT_FLAG_ENCODING_PARAM },
> -    { "pcr_period", "PCR retransmission time",
> +    { "pcr_period", "PCR retransmission time in milliseconds",
>        offsetof(MpegTSWrite, pcr_period), AV_OPT_TYPE_INT,

i suggested it in the past already, but all time and duration values
should be changed to use seconds. It would be much cleaner, consistent
and less confusing.
using actual common day suffixes to indicate milli and micro instead
of having each option use a different unit


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170316/941473af/attachment.sig>