[FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

[Rostislav Pehlivanov]

> static const AVOption ambisonic_options[] = {
> {NULL}
> };

You're missing spaces on the second line here.

> if ((ret = ff_add_format     (&formats, AV_SAMPLE_FMT_FLTP   )) < 0 ||
> (ret = ff_set_common_formats     (ctx    , formats )) < 0 ||
> (ret = ff_add_channel_layout     (&layout , AV_CH_LAYOUT_4POINT0)) < 0 ||
> (ret = ff_set_common_channel_layouts (ctx    , layout   )) < 0)
> return ret;

No indentation.

> AVFilter ff_af_ambisonic = {
> .name      = "ambisonic",
> .description    = NULL_IF_CONFIG_SMALL("An ambisonic filter"),
> .query_formats  = query_formats,
> .priv_size    = sizeof(AmbisonicContext),
> .priv_class  = &ambisonic_class,
> .inputs  = inputs,
> .outputs    = outputs,
> };

Align such that all equal signs are in the same column, look at how other
filters do it.



On 13 March 2017 at 03:12, Sanchit Sinha <sanchit15083 at iiitd.ac.in> wrote:

> On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol <onemda at gmail.com> wrote:
>
> > On 3/12/17, Sanchit Sinha <sanchit15083 at iiitd.ac.in> wrote:
> > > Any changes required in this one?
> >
> > Please do not top post.
> >
> > Expect vertical alignment, no changes are needed.
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
>
>
>
> --
> Sanchit Sinha
> B.Tech- CSE
> IIIT-Delhi
> Roll-2015083
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>