[FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

[wm4]

On Mon, 20 Mar 2017 09:38:15 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2017-03-20 9:35 GMT+01:00 Clément Bœsch <u at pkh.me>:
> > On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote:  
> >> 2017-03-20 8:57 GMT+01:00 Clément Bœsch <git at videolan.org>:  
> >> > ffmpeg | branch: master | Clément Bœsch <u at pkh.me> | Mon Mar 20 08:52:07 2017 +0100| [3835283293bfd38ba69203f4618f0f0f21377bcc] | committer: Clément Bœsch
> >> >
> >> > Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'
> >> >
> >> > * commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08':
> >> >   Drop memalign hack
> >> >
> >> > Merged, as this may indeed be uneeded since
> >> > 46e3936fb04d06550151e667357065e3f646da1a.  
> >>
> >> How are we supposed to test the next crash because
> >> of missing alignment?
> >>  
> >
> > I thought it was only about compatibility with platforms not having
> > an aligned allocator.  
> 
> If you think such platforms exist, one more reason not to merge...

Well we don't think such a platform supported by FFmpeg exists.

> > Do you have a concrete example where it was actually used to
> > debug such issue?  
> 
> The FreeBSD Firefox ticket?
> 
> But it is actually every such ticket: How else can I exclude a compiler /
> toolchain / libc issue?

Just add an assert() verifying alignment before returning from
av_malloc?