[FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

[wm4]

On Mon, 20 Mar 2017 09:59:24 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2017-03-20 9:42 GMT+01:00 Clément Bœsch <u at pkh.me>:
> > On Mon, Mar 20, 2017 at 09:38:15AM +0100, Carl Eugen Hoyos wrote:  
> >> 2017-03-20 9:35 GMT+01:00 Clément Bœsch <u at pkh.me>:  
> >> > On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote:  
> >> >> 2017-03-20 8:57 GMT+01:00 Clément Bœsch <git at videolan.org>:  
> >> >> > ffmpeg | branch: master | Clément Bœsch <u at pkh.me> | Mon Mar 20 08:52:07 2017 +0100| [3835283293bfd38ba69203f4618f0f0f21377bcc] | committer: Clément Bœsch
> >> >> >
> >> >> > Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'
> >> >> >
> >> >> > * commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08':
> >> >> >   Drop memalign hack
> >> >> >
> >> >> > Merged, as this may indeed be uneeded since
> >> >> > 46e3936fb04d06550151e667357065e3f646da1a.  
> >> >>
> >> >> How are we supposed to test the next crash because
> >> >> of missing alignment?
> >> >>  
> >> >
> >> > I thought it was only about compatibility with platforms not having
> >> > an aligned allocator.  
> >>
> >> If you think such platforms exist, one more reason not to merge...  
> >
> > There was apparently MinGW but it seemed to have been fixed
> > (see the hash reference in the merge description).  
> 
> I can only add that the simple idea of removing support for
> platforms without any cause fills me with shame.

All the code in mem.c fills me with shame.

Besides, the memalign hack used to be required, and people still
compile with it forcibly enabled due to cargo-cult. This is
inefficient, so good enough reason to remove.

Of course we shouldn't accidentally drop support for platforms. Can you
tell us which platforms these are?

> Is there really no incentive that would make you work on subtitle
> support in the filter chain?

You're invited to do something more productive as well.