[FFmpeg-devel] [PATCH] clear s->error in avio_read

Michael Niedermayer michael at niedermayer.cc
Mon Mar 20 22:35:22 EET 2017


On Mon, Mar 20, 2017 at 10:21:08AM -0700, Fredrik Hubinette wrote:
> In some cases (when parsing OGG) non-fatal errors can happen, which
> will cause s->error to be set. In most cases, this is not a problem beucase
> s->error is not checked unless an actual error has occurred.  However,
> when avio_read() fails to read more bytes, it checks s->error to decide if
> it just reached the end of the file, or an error occurred. Since s->error is
> not modified if no error occurred, this is not reliable unless we first
> clear
> s->error before reading.
> 
> ---
>  libavformat/aviobuf.c   | 2 ++
> 
>  2 files changed, 7 insertions(+)

how can the issue you describe be reproduced

also thats not a valid git patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170320/0a2b1504/attachment.sig>


More information about the ffmpeg-devel mailing list