[FFmpeg-devel] [PATCH] avcodec/tests: added test for celp_math.c

[Thomas Turner]

On Thu, Mar 23, 2017 at 6:34 AM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

>
> On Thu, Mar 23, 2017 at 02:18:53AM -0700, Thomas Turner wrote:
> > Signed-off-by: Thomas Turner <thomastdt at googlemail.com>
> > ---
> >  libavcodec/Makefile          |  1 +
> >  libavcodec/tests/celp_math.c | 22 ++++++++++++++++++++++
> >  tests/fate/libavcodec.mak    |  5 +++++
> >  3 files changed, 28 insertions(+)
> >  create mode 100644 libavcodec/tests/celp_math.c
> >
> > diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> > index b8d7a00..eae7b8e 100644
> > --- a/libavcodec/Makefile
> > +++ b/libavcodec/Makefile
> > @@ -1023,6 +1023,7 @@ SKIPHEADERS-$(CONFIG_VDPAU)            += vdpau.h
> vdpau_internal.h
> >  SKIPHEADERS-$(CONFIG_VIDEOTOOLBOX)     += videotoolbox.h
> vda_vt_internal.h
> >
> >  TESTPROGS = avpacket
> \
> > +            celp_math
>  \
> >              imgconvert
> \
> >              jpeg2000dwt
>  \
> >              mathops                                                    \
>
> > diff --git a/libavcodec/tests/celp_math.c b/libavcodec/tests/celp_math.c
> > new file mode 100644
> > index 0000000..24cfced
> > --- /dev/null
> > +++ b/libavcodec/tests/celp_math.c
> > @@ -0,0 +1,22 @@
> > +#include "libavutil/libm.h"
>
> missing license header
>
> also fails on x86-32 linux
> can you reproduce it ?
>
yes, was able to reproduce the error after cross-compilation.   Sending in
new patch that fixes the error on 32 bit machines

>
> /home/michael/ffmpeg-git/ffmpeg/tests/fate-run.sh fate-celp_math
> "/home/michael/fatesamples/fate/fate-suite/" "" "/home/michael/ffmpeg-git/ffmpeg/linux32"
> 'run libavcodec/tests/celp_math' '' '/dev/null' '' '1' '' '' '' '' '' '' ''
> ''
>  /home/michael/ffmpeg-git/ffmpeg/linux32/libavcodec/tests/celp_math
> Test celp_math failed. Look at tests/data/fate/celp_math.err for details.
> Assertion 16.94f == r failed at src/libavcodec/tests/celp_math.c:15
> Aborted
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No great genius has ever existed without some touch of madness. --
> Aristotle
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>