[FFmpeg-devel] [PATCH]lavc/xface: Reorder conditions to silence a gcc warning

[Ronald S. Bultje]

Hi,

On Fri, Mar 24, 2017 at 3:53 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2017-02-26 11:07 GMT+01:00 Carl Eugen Hoyos <cehoyos at ag.or.at>:
>
> > I believe attached patch does not change the logic of the conditions
> > but silences a (9 times shown, long-time) gcc warning.
>
> Patch applied.


> -                    if (l >= i && m == j)
> +                    if (l <= 0 || l >= i && m == j)
>                          continue;

Doesn't the compiler complain about mixing || and && without brackets? Some
compilers do, at least, I'd recommend to use an extra set of brackets to
prevent that...

Ronald