[FFmpeg-devel] [PATCH] rtmpproto: send swfverify value as swfurl if latter is unused

[Michael Niedermayer]

On Mon, Mar 20, 2017 at 08:22:51PM +0000, Ricardo Constantino wrote:
> Replicates lavf/librtmp.c behavior in L149-156 and rtmpdump's
> behavior with "--swfVfy <url>" passing the url to swfUrl.
> 
> Fixes trac ticket #5549.
> ---
>  libavformat/rtmpproto.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
> index 5d7ad795ed..cecb6b4d9f 100644
> --- a/libavformat/rtmpproto.c
> +++ b/libavformat/rtmpproto.c
> @@ -341,9 +341,12 @@ static int gen_connect(URLContext *s, RTMPContext *rt)
>      ff_amf_write_field_name(&p, "flashVer");
>      ff_amf_write_string(&p, rt->flashver);
>  
> -    if (rt->swfurl) {
> +    if (rt->swfurl || rt->swfverify) {
>          ff_amf_write_field_name(&p, "swfUrl");
> -        ff_amf_write_string(&p, rt->swfurl);
> +        if (rt->swfurl)
> +            ff_amf_write_string(&p, rt->swfurl);
> +        else
> +            ff_amf_write_string(&p, rt->swfverify);

lavf/librtmp.c adds " swfVfy=1"
why does this here not ?


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170327/4bf9ef41/attachment.sig>