[FFmpeg-devel] [PATCH]lavc/jpeg2000dec: Read resolution box from jp2 files

[Carl Eugen Hoyos]

2017-05-02 16:21 GMT+02:00 Nicolas George <george at nsup.org>:
> Le tridi 13 floréal, an CCXXV, Carl Eugen Hoyos a écrit :
>> Attached patch allows reading the aspect ratio from jpeg2000 files.
>> Kakadu allows to produce samples, the "aspect" is defined as the
>> horizontal and vertical resolution as in tiff.
>
> Did you test what happens with this patch if you try to read two frames
> with the same context (for example with the image2 demuxer), the first
> frame has a non-square-pixels resolution defined and the second has no
> resolution indication at all?
>
> The correct result would be to have a sample aspect ratio on the first
> frame and not on the second.
>
> But with this code, since the first resolution is stored in the context
> and never cleared, it looks like it will be kept for the remaining
> images.

New, fixed patch attached.
(There also was another bug.)

Thank you, Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-jpeg2000dec-Read-the-sample-aspect-ratio-from-t.patch
Type: text/x-patch
Size: 3591 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170502/0f78bf01/attachment.bin>