[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

[Muhammad Faiz]

On Sat, May 6, 2017 at 9:35 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Fri, May 5, 2017 at 12:17 PM, Nicolas George <george at nsup.org> wrote:
>
>> Le sextidi 16 floréal, an CCXXV, Hendrik Leppkes a écrit :
>> > Blocking crash fixes on silly arguments doesn't help anyone. Send a
>>
>> My argument is not silly: the code to align the frame will be needed,
>> but NOT HERE.
>
>
> I actually think this is a fair point. I've hated the swscale frame
> alignment code for ages, and this can effectively be used to clean that up
> also. We could even start making padding requirements which would make
> swscale SIMD writing a LOT easier.
>
> Let's think about this a little bit guys. Nicolas may be overly aggressive,
> but he has a good point.

+1

But, my point is:
Because the design of handling data alignment may take long time to
discuss, and also it may add new features which can't be backported,
we need temporal fix.
There are two choices:
 - fix libmp3lame (previous patch) and filters/codecs that need aligned data
 - fix framequeue (this patch).
And I think, fixing framequeue is more elegant.

I think, Nicolas was afraid that if the crash is fixed, people will
not be aware again with the alignment problem and will not discuss it.

Thank's.