[FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_realign().

Ronald S. Bultje rsbultje at gmail.com
Sun May 7 20:21:03 EEST 2017


Hi,

On Sun, May 7, 2017 at 7:50 AM, Nicolas George <george at nsup.org> wrote:

> L'octidi 18 floréal, an CCXXV, Ronald S. Bultje a écrit :
> > My understanding from what Nicolas said is that the goal is to have
> > higher-level code (utils.c-level, e.g. the callers of filter() or
> > encode_frame() or get_buffer() inside decode_frame()) call this for every
> > input frame going back to a caller with higher alignment requirements
> than
>                               ^^^^^^
> > the input frame (possibly with a one-time warning)?
>
> I think you should have written "callee" here.


Indeed, my bad.

Apart from that, this is exactly that, thanks.


OK, I think I agree with that design in principle.

Hendrik is also right that it wouldn't be called after the get_buffer()
user callback to _make_ the buffer aligned, but rather just to check that
the buffer _is_ aligned. (If it isn't aligned, we would probably return an
error from get_buffer.)

Ronald


More information about the ffmpeg-devel mailing list