[FFmpeg-devel] [PATCH 2/3] lavc: add a framework to fix alignment problems.

Ronald S. Bultje rsbultje at gmail.com
Sun May 7 22:03:43 EEST 2017


Hi,

On Sun, May 7, 2017 at 2:55 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Sun, May 7, 2017 at 7:17 PM, Ronald S. Bultje <rsbultje at gmail.com>
> wrote:
> > Hi,
> >
> > On Sun, May 7, 2017 at 11:15 AM, Hendrik Leppkes <h.leppkes at gmail.com>
> > wrote:
> >
> >> Ronald suggested on IRC that the only parts suffering from this are
> >> the ASM DSP components, and we should just make checkasm tests for all
> >> of them and let checkasm test the alignment they claim to support, but
> >> alas this won't be done for months, if not years.
> >
> >
> > This really isn't that complicated once we get the general design and
> goals
> > explicitly documented.
> >
> > We test all kind of crazy stuff in checkasm, like xmm register
> clobbering.
> > This is just another strange thing that can be done in generic code. We
> > just need to decide what is OK so we know what to test.
> >
>
> I'm not worried about checkasm perfoming the test, but all DSP
> components actually having tests.


Test coverage in general is a fair point, we can work on that...

Ronald


More information about the ffmpeg-devel mailing list