[FFmpeg-devel] [PATCH] avformat/rtsp: check return value of read in ff_rtsp_read_reply()

[Daniel Richard G.]

Resending. Are there any objections to this patch?

On Mon, 2017 Apr 17 01:12-0400, Daniel Richard G. wrote:
> In the course of testing RTSP streaming of CCTV video via the FFmpeg
> API, I have found some Valgrind uninitialized-memory errors due to what
> appear to be short/failed reads in ffurl_read_complete().
> 
> The calling function ff_rtsp_read_reply() was not checking the return
> value, and so the library went on to parse garbage in an
> uninitialized heap-allocated buffer.
> 
> The attached patch adds logic to check the return value and bail
> out on error.
> 
> 
> --Daniel
> 

-- 
Daniel Richard G. || skunk at iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-return-value-of-read-in-ff_rtsp_read_reply.patch
Type: text/x-patch
Size: 981 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170508/529aecf8/attachment.bin>