[FFmpeg-devel] [PATCH v10] - Added Turing codec interface for ffmpeg

[Saverio Blasi]

Dear all,

First of all thank you very much for all the help you provided with this patch. We are now at the tenth iteration, and the patch greatly improved since the first time we submitted it. In fact most of the lines of code in the current version of the patch were suggested by you or revised many times already.

Regarding the implementation of the cmd parsing, as Hendrik is pointing out below, we followed other similar approaches (of other codecs). We already revised this implementation following your comments in previous iterations of this patch. At this stage, we would prefer to avoid changing again its structure and keep the implementation as it is, because this gives us more flexibility and also aligns it with other similar projects already integrated with ffmpeg.

We would appreciate if you could let us know the procedure from here on for integration of this patch within the ffmpeg project.

Thank you,
All the best,
Saverio

>> Dear Michael,
>>
>>>> Why do you pass a single string of all options and then manually
>>>> parse all options out of it instead of specifying the options each in
>>>> teh AVOption array ?
>>>>
>>> We prefer to pass a single string so that we can be more flexible how
>>> we then parse it and what to do with it. This gives us more freedom
>>> in the future in case we decide to change some of the codec APIs, so
>>> that we do not need to change the interface with FFmpeg.
>>
>> That is unacceptable.

> libx264 and 265 pass options the same way, what exactly is the problem with that?




-----------------------------
http://www.bbc.co.uk
This e-mail (and any attachments) is confidential and
may contain personal views which are not the views of the BBC unless specifically stated.
If you have received it in
error, please delete it from your system.
Do not use, copy or disclose the
information in any way nor act in reliance on it and notify the sender
immediately.
Please note that the BBC monitors e-mails
sent or received.
Further communication will signify your consent to
this.
-----------------------------