[FFmpeg-devel] [PATCH] libavformat aviobuf: Fixed dst pointer initialization in fill_buffer

[wm4]

On Mon, 15 May 2017 17:55:28 +0000
Rob Meyers <robertmeyers-at-google.com at ffmpeg.org> wrote:

> Of course.
> 
> We noticed when reading data from a named pipe the first 10 bytes would get
> dropped. I traced this to the affected code in fill_buffer(). The
> assignment of "dst" was always set to the beginning of the buffer, and if
> it hadn't been consumed yet the data would be overwritten. We could
> reproduce this by setting up a server that writes to the named pipe in two
> small (6 byte) messages with a 1 second gap between. Without the gap, or if
> the data is sent as one message, there's no problem. It's in the
> accumulation of data between messages to fulfill a read that this bug is
> triggered.

Well, that explanation should be in the commit message (with a short 70
char summary as subject line). Not just "fixed $thing".