[FFmpeg-devel] [PATCH] Disable MSA optimization for big endian arch

[Shivraj Patil]

Shivraj: yes, -mmsa flag will be added and should not be an issue for big endian mips builds.

> +    if enabled bigendian && enabled msa; then
> +        disable msa
> +    fi

As currently, MSA optimizations does not support big endian, above code will disable MSA and switch to default C functions.




-----Original Message-----
From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Michael Niedermayer
Sent: 16 May 2017 20:22
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] Disable MSA optimization for big endian arch

On Mon, Apr 24, 2017 at 05:33:22PM +0530, shivraj.patil at imgtec.com wrote:
> From: Shivraj Patil <shivraj.patil at imgtec.com>
> 
> Signed-off-by: Shivraj Patil <shivraj.patil at imgtec.com>
> ---
>  configure |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configure b/configure
> index 1e3463c..c63a48a 100755
> --- a/configure
> +++ b/configure
> @@ -5357,6 +5357,10 @@ elif enabled mips; then
>      enabled mipsdsp && check_inline_asm_flags mipsdsp '"addu.qb $t0, $t1, $t2"' '-mdsp'
>      enabled mipsdspr2 && check_inline_asm_flags mipsdspr2 '"absq_s.qb $t0, $t1"' '-mdspr2'
>  
> +    if enabled bigendian && enabled msa; then
> +        disable msa
> +    fi


the order of this looks a bit odd
for example there is above:
enabled mipsfpu && enabled msa && check_inline_asm_flags msa '"addvi.b $w0, $w1, 1"' '-mmsa' && check_header msa.h || disable msa

I think this would add -mmsa to the flags or disable msa already

with the code you add msa is disabled but -mmsa is left in the flags

Please correct me if iam wrong.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire