[FFmpeg-devel] [PATCH] Disable MSA for big-endian mips cpu

Shivraj Patil Shivraj.Patil at imgtec.com
Fri May 26 16:56:00 EEST 2017


The current upstreamed code has been written and tested for Little Endian systems.
We do have plans to add the Big Endian support in near future, but till that time, need to disable all to avoid its usage and failures.

-----Original Message-----
From: Michael Niedermayer [mailto:michael at niedermayer.cc] 
Sent: 26 May 2017 19:13
To: FFmpeg development discussions and patches
Cc: Shivraj Patil
Subject: Re: [FFmpeg-devel] [PATCH] Disable MSA for big-endian mips cpu

On Fri, May 26, 2017 at 03:40:20PM +0200, Michael Niedermayer wrote:
> On Fri, May 26, 2017 at 04:08:55PM +0530, shivraj.patil at imgtec.com wrote:
> > From: Shivraj Patil <shivraj.patil at imgtec.com>
> > 
> > Signed-off-by: Shivraj Patil <shivraj.patil at imgtec.com>
> > ---
> >  libavcodec/mips/Makefile                    |    2 ++
> >  libavcodec/mips/blockdsp_init_mips.c        |    8 ++++----
> >  libavcodec/mips/h263dsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/h264chroma_init_mips.c      |    8 ++++----
> >  libavcodec/mips/h264dsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/h264pred_init_mips.c        |    8 ++++----
> >  libavcodec/mips/h264qpel_init_mips.c        |    8 ++++----
> >  libavcodec/mips/hevcdsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/hevcpred_init_mips.c        |    8 ++++----
> >  libavcodec/mips/hpeldsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/idctdsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/me_cmp_init_mips.c          |    8 ++++----
> >  libavcodec/mips/mpegvideo_init_mips.c       |    8 ++++----
> >  libavcodec/mips/mpegvideoencdsp_init_mips.c |    8 ++++----
> >  libavcodec/mips/pixblockdsp_init_mips.c     |    8 ++++----
> >  libavcodec/mips/qpeldsp_init_mips.c         |    8 ++++----
> >  libavcodec/mips/vp8dsp_init_mips.c          |    8 ++++----
> >  libavcodec/mips/vp9dsp_init_mips.c          |    8 ++++----
> >  18 files changed, 70 insertions(+), 68 deletions(-)
> 
> Why does none of this code work on big endian mips ?
> 
> Is it difficult to make it work ?
> 
> Is it certain that the "disabled" code does not work on big endian 
> mips ?
> 
> Is it known that the reason for it not working is the endianness or 
> could it be a unrelated issue that makes it work on neither endianness?

and i forgot the CC, so repling with CC (sorry)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus


More information about the ffmpeg-devel mailing list