[FFmpeg-devel] [PATCH 09/11] avcodec/blockdsp: roll-up x86asm preprocessor loop

Martin Vignali martin.vignali at gmail.com
Thu Nov 9 21:46:44 EET 2017


2017-11-09 12:58 GMT+01:00 James Darnley <jdarnley at obe.tv>:

> From: James Darnley <james.darnley at gmail.com>
>
> ---
>  libavcodec/x86/blockdsp.asm | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm
> index 9d203df8f5..9d0e8a3242 100644
> --- a/libavcodec/x86/blockdsp.asm
> +++ b/libavcodec/x86/blockdsp.asm
> @@ -38,22 +38,19 @@ cglobal clear_block, 1, 1, %1, blocks
>  %assign %%i 0
>  %rep %2
>      mova  [blocksq+mmsize*(0+%%i)], m0
>
>
> do you still need (0+%%i ) ?
Maybe (untested), %%i is enough ?

otherwise lgtm.

Martin


More information about the ffmpeg-devel mailing list