[FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

[James Almer]

On 11/16/2017 9:22 PM, Derek Buitenhuis wrote:
> On 11/16/2017 6:34 PM, Devin Heitmueller wrote:
>> +                uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + audio_offset;
>> +                for (int x = 0; x < pkt.size; x += sample_size) {
> 
> I realize this is C++, but I'm not sure if we still try to stick
> to our C style (aka no mixed variable decls) in our C++ too.
> 
> Not familiar enough with decklink stuff to review this properly,
> though.
> 
> - Derek

Whatever compiler had issues with mixed code and decl will probably
either have no issues with c++98, or just not support c++ at all.
Also, I see a bunch of for (int ...) lines in decklink sources already,
so IMO no point changing that now.