[FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

[刘歧]

> 在 2017年11月16日，17:01，Dixit, Vishwanath <vdixit at akamai.com> 写道：
> 
> 
> 
>> On 11/16/17, 12:09 PM, "刘歧" <lq at chinaffmpeg.org> wrote:
>> 
>>   FATE test passed:  Ubuntu, OS X, qemu+MIPS Linux,  wine MingW, qemu+ARM Linux, Thanks.
>> 
>> +    if (p) {
>>   +        strcpy(extension, p);
>>   What about use av_strlcpy ?
>> 
>> +        while (q < varstr + strlen(varstr)) {
>>  +            if (!strncmp(q, "a:", 2) || !strncmp(q, "v:", 2) ||
>>  +                !strncmp(q, "s:", 2))
>>  What about use av_strcasecmp ?
>> 
>> +            } else {
>>   +                av_log(s, AV_LOG_ERROR, "Invalid keyval %s\n", keyval);
>>   +                return -1;
>>   What about use return AVERROR(EINVAL)?
>> 
>> +            } else {
>>  +                av_log(s, AV_LOG_ERROR, "Unable to map stream at %s\n", keyval);
>>  +                return -1;
>>  same as above.
>> 
>> +            strrchr(master_url, '\\');
>>   +    if (p) {
>>   +        base_len = abs(p - master_url);
>>   use FFABS
>> 
>>  +        if (strncmp(master_url, media_url, base_len)) {
>>  use av_strcasecmp
> 
> I have made updates for all the review comments. Please find the updated patch set in the attachment.
> 
> 
> <0001-avformat-hlsenc-creation-of-hls-variant-streams-in-a.patch><0002-avformat-hlsenc-creation-of-hls-master-playlist-file.patch><0003-tests-fate-addition-of-test-case-for-hls-variant-str.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

pushed!