[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

[Jeyapal, Karthick]

>On 11/22/17, 2:18 PM, "Hendrik Leppkes" <h.leppkes at gmail.com> wrote:

>>On Wed, Nov 22, 2017 at 9:35 AM, Jeyapal, Karthick <kjeyapal at akamai.com> wrote:
>>>On 11/22/17, 1:47 PM, "刘歧" <lq at chinaffmpeg.org> wrote:
[…]
>>> move the APIs to an C source file, and use ff_ prefix, refer to: https://ffmpeg.org/developer.html#toc-Naming-conventions
>> Thanks for the reply.
>> I am not adding it to the API or a global function.
>> Those are just ‘static’ utility functions, to allow code reuse.
>> The scope will be limited only to those files including hlsenc.h.
>> Developer guide states “For file-scope variables and functions declared as static, no prefix is required”.
>> For example, oggdec.h has two static functions without ff_ prefix.
>>
>
>Regardless, having a bunch of complex functions in a header is not the
>preferred way (because their code gets duplicated), its usually
>reserved for extremely simple functions or special cases. Instead, put
>them into a .c file and give them the ff_ prefix, like most common
>shared code we use.
Thanks for the clarification. 
I have uploaded newer patch set v2 with those functions in .c file 
>
>- Hendrik

regards,
Karthick