[FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

Matthias Troffaes matthias.troffaes at gmail.com
Wed Nov 29 22:56:00 EET 2017


Dear Mark,

On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid <mindmark at gmail.com> wrote:
> @@ -1445,12 +1463,13 @@ static int mxf_write_header_metadata_sets(AVFormatContext *s)
>      AVDictionaryEntry *entry = NULL;
>      AVStream *st = NULL;
>      int i;
> -
> -    MXFPackage packages[2] = {};
> +    MXFPackage packages[3] = {};

Here, may I suggest

MXFPackage packages[3] = {0};

for C99 compliance? For instance, msvc does not support an empty
struct initializer. See for instance
https://stackoverflow.com/questions/17589533/is-an-empty-initializer-list-valid-c-code

Kind regards,
Matthias


More information about the ffmpeg-devel mailing list