[FFmpeg-devel] [PATCH 2/2] configure: add pkg-config check for openal

[Hendrik Leppkes]

On Wed, Nov 29, 2017 at 9:39 PM, Stephen Hutchinson <qyot27 at gmail.com> wrote:
> ---
>  configure | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 3c08125da3..141c8b742f 100755
> --- a/configure
> +++ b/configure
> @@ -5952,11 +5952,13 @@ enabled mmal              && { check_lib mmal interface/mmal/mmal.h mmal_port_co
>                                   check_lib mmal interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host; } ||
>                                 die "ERROR: mmal not found" &&
>                                 check_func_headers interface/mmal/mmal.h "MMAL_PARAMETER_VIDEO_MAX_NUM_CALLBACKS"; }
> -enabled openal            && { { for al_extralibs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do
> -                               check_lib openal 'AL/al.h' alGetError "${al_extralibs}" && break; done } ||
> -                               die "ERROR: openal not found"; } &&
> -                             { check_cpp_condition "AL/al.h" "defined(AL_VERSION_1_1)" ||
> -                               die "ERROR: openal must be installed and version must be 1.1 or compatible"; }
> +enabled openal            && { check_pkg_config openal openal AL/al.h alGetError ||
> +                               { { for al_extralibs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do
> +                                 check_lib openal 'AL/al.h' alGetError "${al_extralibs}" && break; done } &&
> +                                 warn "using openal without pkg-config"; ||
> +                                 die "ERROR: openal not found"; } &&
> +                               { check_cpp_condition "AL/al.h" "defined(AL_VERSION_1_1)" ||
> +                                 die "ERROR: openal must be installed and version must be 1.1 or compatible"; } }


The same applies here as with twolame, we don't really want to
duplicate all sorts of checks, so if pkg-config has been available for
a sufficiently long time, then just use it always.

- hendrik