[FFmpeg-devel] [FFmpeg-devel 1/1] avcodec/samidec: check av_strdup() return value

[Clément Bœsch]

On Mon, Nov 27, 2017 at 02:56:32PM +0800, Pan Bian wrote:
> In function sami_paragraph_to_ass(), the return value of av_strdup() is
> not checked. To avoid potential NULL dereference, the return value
> should be checked against NULL.
> 
> Signed-off-by: Pan Bian <bianpan2016 at 163.com>
> ---
> V2: fix patcheck warnings
> ---
>  libavcodec/samidec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c
> index 2620424..6a59806 100644
> --- a/libavcodec/samidec.c
> +++ b/libavcodec/samidec.c
> @@ -48,6 +48,9 @@ static int sami_paragraph_to_ass(AVCodecContext *avctx, const char *src)
>      AVBPrint *dst_content = &sami->encoded_content;
>      AVBPrint *dst_source = &sami->encoded_source;
>  
> +    if (!dupsrc)
> +        return AVERROR(ENOMEM);
> +
>      av_bprint_clear(&sami->encoded_content);
>      av_bprint_clear(&sami->content);
>      av_bprint_clear(&sami->encoded_source);

Patch applied, thanks

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171129/aa3d8906/attachment.sig>