[FFmpeg-devel] [PATCH] avcodec/dnxhddec: Do not overwrite colorspace if the container has set it.

Michael Niedermayer michael at niedermayer.cc
Thu Nov 30 03:41:25 EET 2017


On Tue, Nov 28, 2017 at 04:49:46PM -0800, Steven Robertson wrote:
> The existing logic overrides container metadata even in cases where the
> container metadata must be trusted (e.g. HDR). The original spec had no
> provision for specifying color volume, so many files rely on the
> assumption of Rec. 709.
> 
> An update to the spec included a 'clv' field for explicitly signaling
> that the container should be trusted in an existing bitfield in the
> frame header, but the default of 0 from old encoders forces Rec. 709,
> which would break any HDR stream. Because there is no place in DNxHR for
> specifying a transfer function, DNxHR HDR files must include
> container-level color information.
> 
> This patch maintains the existing behavior of choosing the 709 over the
> 601 matrix when container-level information is missing, and allows
> container-level information to win if present.
> 
> Signed-off-by: Steven Robertson <steven at strobe.cc>
> ---
>  libavcodec/dnxhddec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
> index f46e41a456..6f8c716412 100644
> --- a/libavcodec/dnxhddec.c
> +++ b/libavcodec/dnxhddec.c

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171130/b8dc63e3/attachment.sig>


More information about the ffmpeg-devel mailing list