[FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

[Mark Reid]

On Wed, Nov 29, 2017 at 8:19 PM, Mark Reid <mindmark at gmail.com> wrote:

>
>
> On Wed, Nov 29, 2017 at 12:56 PM, Matthias Troffaes <
> matthias.troffaes at gmail.com> wrote:
>
>> Dear Mark,
>>
>> On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid <mindmark at gmail.com> wrote:
>> > @@ -1445,12 +1463,13 @@ static int mxf_write_header_metadata_sets(AVFormatContext
>> *s)
>> >      AVDictionaryEntry *entry = NULL;
>> >      AVStream *st = NULL;
>> >      int i;
>> > -
>> > -    MXFPackage packages[2] = {};
>> > +    MXFPackage packages[3] = {};
>>
>> Here, may I suggest
>>
>> MXFPackage packages[3] = {0};
>>
>> for C99 compliance? For instance, msvc does not support an empty
>> struct initializer. See for instance
>> https://stackoverflow.com/questions/17589533/is-an-empty-
>> initializer-list-valid-c-code
>>
>> Kind regards,
>> Matthias
>>
>
> sorry about that! yes I'll send a patch fixing that.
>

clang give me a warning telling to do this instead
packages[3] = {{0}};
I assume thats correct as I see thats used throughout the codebase.


>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
>