[FFmpeg-devel] [PATCH 3/3] avcodec/proresdec2: Use LAST_SKIP_BITS where possible

[Michael Niedermayer]

On Sun, Oct 01, 2017 at 11:54:22PM -0300, James Almer wrote:
> On 10/1/2017 11:18 PM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/proresdec2.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c
> > index 22dc70eeb4..9647aa7ebc 100644
> > --- a/libavcodec/proresdec2.c
> > +++ b/libavcodec/proresdec2.c
> > @@ -250,7 +250,7 @@ static int decode_picture_header(AVCodecContext *avctx, const uint8_t *buf, cons
> >      return pic_data_size;
> >  }
> >  
> > -#define DECODE_CODEWORD(val, codebook)                                  \
> > +#define DECODE_CODEWORD(val, codebook, SKIP_BITSf)                      \
> 
> Nit: SKIP.
> 
> SKIP_BITSf is kinda ugly.

will change it to SKIP and apply

will also apply the rest of the set

thanks


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171003/acd88d9d/attachment.sig>