[FFmpeg-devel] [PATCH] avformat: fix id3 chapters

[Lukas Stabe]

> On 5. Oct 2017, at 09:08, Paul B Mahol <onemda at gmail.com> wrote:
> 
> On 10/5/17, Lukas Stabe <lukas at stabe.de> wrote:
>> These changes store id3 chapter data in ID3v2ExtraMeta and introduce
>> ff_id3v2_parse_chapters to parse them into the format context if needed.
>> 
>> Encoders using ff_id3v2_read, which previously parsed chapters into the
>> format context automatically, were adjusted to call ff_id3v2_parse_chapters.
>> ---
>> libavformat/aiffdec.c  |   3 +-
>> libavformat/asfdec_f.c |   4 +-
>> libavformat/asfdec_o.c |   4 +-
>> libavformat/dsfdec.c   |   4 +-
>> libavformat/id3v2.c    | 120
>> ++++++++++++++++++++++++++++++++++++-------------
>> libavformat/id3v2.h    |  15 +++++--
>> libavformat/iff.c      |   3 +-
>> libavformat/omadec.c   |   5 +++
>> libavformat/utils.c    |   2 +
>> 9 files changed, 122 insertions(+), 38 deletions(-)
>> 
> 
> 
> Fix? It wasn't broken at all.

It was. I forgot to link the issue in the commit message, but see here https://trac.ffmpeg.org/ticket/6558 for details on how it was broken and when.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171005/d4d27079/attachment.sig>