[FFmpeg-devel] [PATCH] avformat/srt: add Haivision Open SRT protocol

[Nicolas George]

Le primidi 21 vendémiaire, an CCXXVI, nablet developer a écrit :
> that's true - 90% of your comments are for original udp.c code I didn't
> touch.

When you are copy-pasting code, you are not only copy-pasting features,
you are also copy-pasting bugs and maintenance burden. When a bug is
found in udp.c, or when a change is needed due to changes in other parts
of the code, it will require the same fix to be made in opensrt.c:
useless work duplication. Furthermore, since this feature is a protocol
that nobody uses (yet?) depending on a library that nobody has (not in
Debian AFAICS), there will be very little testing, so the bugs will not
be found, and will stay.

And since it is a network protocol, bugs are likely to be
security-relevant.

Therefore, this level of code duplication (that I had not noticed until
now, I has not looked at the code) is a big no.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171012/457231bc/attachment.sig>