[FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

Thilo Borgmann thilo.borgmann at mail.de
Thu Oct 19 01:41:11 EEST 2017


Am 18.10.17 um 16:02 schrieb Compn:
> On Wed, 4 Oct 2017 11:34:18 +0200, wm4 <nfxjfg at googlemail.com> wrote:
> 
>>> more so, opaque_ref is used in only 5 lines in the whole codebase,
>>> so there is not much code to consider when using a different solution
>>
>> We shouldn't add such special fields, we have enough hacks already. Is
>> that your only suggestion how to do this? Because it's a bad one.
> 
> michael, do you have other suggestions how to solve this problem? are
> you going to fix the errors in the doxygen that you noticed due to
> merges?
> 
> wm4, would you object to adding another special field? if
> someone else edited this and made a patch?

If the two of you could agree on an alternate, suitable approach, I could offer
to do the codemonkey's work like compn suggested. However, I still lack some
knowledge about API and HWACCEL which would result in certain inefficiency in
doing so. OTOH this comes along with a nonbiased perspective which might be a
positive thing here.

I'd appreciate it if anyone else would be willing to commit some coding to a
solution, though. I am not eager to do it but I can if we stall completely
otherwise.

-Thilo


More information about the ffmpeg-devel mailing list