[FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

[James Almer]

On 10/18/2017 7:49 PM, Reino Wijnsma wrote:
> On 19-10-2017 0:22, James Almer <jamrial at gmail.com> wrote:
>> It think the following should be enough:
>>> enabled libopenjpeg       && { use_pkg_config libopenjpeg "libopenjp2 >= 2.1.0" openjpeg.h opj_version ||
>>>                                { require_pkg_config libopenjpeg "libopenjp2 >= 2.1.0" openjpeg.h opj_version -DOPJ_STATIC && add_cppflags -DOPJ_STATIC; } }
>> To make sure -DOPJ_STATIC is not used unless strictly necessary.
> 
> Works overhere. No errors.
> 
> A bit off-topic, but can you explain to me why you (FFmpeg developers)
> /have/ added -DOPJ_STATIC to libopenjpeg in the past, but /haven't/
> added -DCACA_STATIC, -DMODPLUG_STATIC and -DLIBTWOLAME_STATIC to
> libcaca, libmodplug and libtwolame?

Different developers/maintainers, different amount of users reporting
issues with one library compared to another, etc.

> 
> -- Reino
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>