[FFmpeg-devel] [PATCH] fate: change fate-ffmpeg-attached_pics to encode to pcm_s16le

[Marton Balint]

On Fri, 27 Oct 2017, James Almer wrote:

> On 10/27/2017 5:54 PM, Marton Balint wrote:
>> Previously alac encoder was used, from a first glance I thought it is bitexact,
>> but it turns out it is using floating point arithmetic as well, so probably it
>> is not. Fixes fate failures on mingw32/64.
>> 
>> Signed-off-by: Marton Balint <cus at passwd.hu>
>> ---
>>  tests/fate/ffmpeg.mak               |   4 +-
>>  tests/ref/fate/ffmpeg-attached_pics | 259 ++++++++++++++++++------------------
>>  2 files changed, 131 insertions(+), 132 deletions(-)
>> 
>> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
>> index a806c05d45..9a822f64bb 100644
>> --- a/tests/fate/ffmpeg.mak
>> +++ b/tests/fate/ffmpeg.mak
>> @@ -31,8 +31,8 @@ FATE_FFMPEG-$(call ALLYES, AEVALSRC_FILTER ASETNSAMPLES_FILTER AC3_FIXED_ENCODER
>>  fate-ffmpeg-filter_complex_audio: CMD = framecrc -filter_complex "aevalsrc=0:d=0.1,asetnsamples=1537" -c ac3_fixed
>>
>>  # Ticket 6375
>> -FATE_SAMPLES_FFMPEG-$(call ALLYES, MOV_DEMUXER PNG_DECODER ALAC_DECODER ALAC_ENCODER) += fate-ffmpeg-attached_pics
>> -fate-ffmpeg-attached_pics: CMD = threads=2 framecrc -i $(TARGET_SAMPLES)/lossless-audio/inside.m4a -acodec alac -max_muxing_queue_size 16
>> +FATE_SAMPLES_FFMPEG-$(call ALLYES, MOV_DEMUXER PNG_DECODER ALAC_DECODER PCM_S16LE_ENCODER RAWVIDEO_ENCODER) += fate-ffmpeg-attached_pics
>> +fate-ffmpeg-attached_pics: CMD = threads=2 framecrc -i $(TARGET_SAMPLES)/lossless-audio/inside.m4a -acodec pcm_s16le -max_muxing_queue_size 16
>
> Change -acodec to -c:a while at it.

Ok, will do.

>
> Why is the ticket #6375 still open? If this is a test for said
> regression, i assume it was fixed?

The ticket contains reports from more than one user, only the use case of 
"NoX" is fixed.

Regards,
Marton