[FFmpeg-devel] [PATCH 1/7] dashenc: fix bitrate estimation with correct scaling

[Michael Niedermayer]

On Thu, Oct 26, 2017 at 05:58:34PM +0200, Peter Große wrote:
> From: Anton Schubert <ischluff at mailbox.org>
> 
> Signed-off-by: Anton Schubert <ischluff at mailbox.org>
> ---
>  libavformat/dashenc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 240ff41380..a4b37403d6 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -953,6 +953,7 @@ static int dash_flush(AVFormatContext *s, int final, int stream)
>  
>      for (i = 0; i < s->nb_streams; i++) {
>          OutputStream *os = &c->streams[i];
> +        AVStream *st = s->streams[i];
>          char filename[1024] = "", full_path[1024], temp_path[1024];
>          int range_length, index_length = 0;
>  
> @@ -1007,7 +1008,9 @@ static int dash_flush(AVFormatContext *s, int final, int stream)
>  
>          if (!os->bit_rate) {
>              // calculate average bitrate of first segment
> -            int64_t bitrate = (int64_t) range_length * 8 * AV_TIME_BASE / (os->max_pts - os->start_pts);
> +            int64_t bitrate = (int64_t) range_length * 8 * AV_TIME_BASE / av_rescale_q(os->max_pts - os->start_pts,
> +                                                                                       st->time_base,
> +                                                                                       AV_TIME_BASE_Q);

this looks like it does scaling twice (AV_TIME_BASE)

is that intended ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171028/df45159a/attachment.sig>