[FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

[Devin Heitmueller]

> On Oct 25, 2017, at 2:23 PM, Marton Balint <cus at passwd.hu> wrote:
> 
> 
> On Fri, 6 Oct 2017, Devin Heitmueller wrote:
> 
>> From: Devin Heitmueller <dheitmueller at kernellabs.com <mailto:dheitmueller at kernellabs.com>>
>> 
>> Hook in libklvanc and use it for output of EIA-708 captions over
>> SDI.  The bulk of this patch is just general support for ancillary
>> data for the Decklink SDI module - the real work for construction
>> of the EIA-708 CDP and VANC line construction is done by libklvanc.
>> 
>> Libklvanc can be found at: https://github.com/stoth68000/libklvanc <https://github.com/stoth68000/libklvanc>
> 
> Sorry for the delay, I had little time lately. In general I think it is OK to put VANC functionality into a library, but libklvanc does not seem like a very mature one, it has some pretty generic function names without namespacing, e.g. "generate_vanc_line". Or it is using simple printf for the dumper functions. You plan to work on these kind of issues to make it more like a "stable" generic library?

Yeah, the name spacing and logging are known issues and have been on my todo list for a while.  The focus has been on the core functionality for VANC management and protocol support, and there clearly needs a bit more polish on some of the peripheral areas.

Thanks for providing feedback.  I will incorporate your suggestions and submit a revised patch this week.

Regards,

Devin