[FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

[wm4]

On Tue, 5 Sep 2017 10:03:11 +0200
Clément Bœsch <u at pkh.me> wrote:

> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote:
> [...]
> > > > > Can't we just remove this codec? It has no use other than causing
> > > > > potential security issues and maintenance.    
> > > > 
> > > > I agree about removing the encoder, but the decoder is needed for
> > > > existing streams. Unless everyone just argues it has no real world
> > > > samples for being an avcodec-only toy codec.
> > > > 
> > > > If you send a patch removing the encoder without also trying to remove
> > > > all the things that currently depend on it (One or two filters i think)
> > > > then I'll +1 it. ffv1 and mpeg4 encoders are enough for any kind of
> > > > testing, fate or otherwise, that might require a native encoder.    
> > > 
> > > I find it a bit offensive that people suggest to remove the encoder i
> > > maintain.  
> > 
> > Can I add my own unused fringe codec with no users, as long as I
> > maintain it?  
> 
> Is there any reason to be so obsessed with snow? There are plenty of other
> "fringe" codecs in the codebase that only one person in the world cared
> about 10 years ago. Snow is one of the rare wavelet codecs, and as a
> result is much more valuable than many random basic game flavored codecs.
> And somehow, no one ever mention those.

Those game codecs have actually some use. There are files in the wild
that are available to many, and that aren't just demo/test files. But
it's true that all these game codecs bloat the codebase, cause
maintenance and security issues, and have little use. They barely have
a justification to exist too.

The only argument for snow is that it's a nice ideas. It might serve as
some proof of concept. As a real codec, it appears to be unusable.

> I don't personally care about game codecs or snow myself (probably nobody
> does), but I don't support this snow/swscale/whatever-michael-did killing
> circle jerk. This really feels like some form of constant harassment (I'm
> not even talking about IRC), and that's not acceptable.

Well, michael could just cut back on trying to force insane stuff. His
obstinate attitude to force ridiculous patches and defending them like
they're the only choice doesn't help. Even when we try to remove some
of his sins, he'll defend it to death, no matter how crazy and stupid
the code was (side data merging comes to mind).

If you feel like what I'm doing is harassment, I can end my involvement
with michael to avoid this - but only if you stop him from doing bad
things.

> Please people, chill out. I understand the frustration when someone
> doesn't understand something that feel obvious to "everyone" and keep
> insisting on it, but that doesn't mean you should enter in some form of
> obsession and vengeance about anything he did/does/will do.
> 
> ...aaand here I am, back in the "Insane people defending Michael all the
> time" category.

We don't really need more of that category.