[FFmpeg-devel] [PATCH 2/2] fate/fits: add missing png & gif dependencies

[Michael Niedermayer]

On Sat, Sep 16, 2017 at 02:00:28AM +0530, Paras Chadha wrote:
> Signed-off-by: Paras Chadha <paraschadha18 at gmail.com>
> ---
>  tests/fate/fits.mak | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak
> index bc1b771..704f655 100644
> --- a/tests/fate/fits.mak
> +++ b/tests/fate/fits.mak
> @@ -1,3 +1,4 @@
> +tests/data/fits-multi.fits: $(TARGET_SAMPLES)/gif/m4nb.gif
>  tests/data/fits-multi.fits: TAG = GEN
>  tests/data/fits-multi.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
>  	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
> @@ -10,6 +11,7 @@ map.tests/data/lena-gbrp.fits    := rgb24
>  map.tests/data/lena-gbrp16.fits  := rgb48
>  map.tests/data/lena-gbrap16.fits := rgba64
>  
> +tests/data/lena%.fits: $(TARGET_SAMPLES)/png1/lena-$(map.$(@)).png
>  tests/data/lena%.fits: TAG = GEN
>  tests/data/lena%.fits: NAME = $(map.$(@))
>  tests/data/lena%.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data

This likely should contain changes like this:
or something equivalent

diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak
index bc1b771a52..36a751a372 100644
--- a/tests/fate/fits.mak
+++ b/tests/fate/fits.mak
@@ -39,7 +39,7 @@ fate-fitsdec%: CMD = framecrc -i $(SRC) -pix_fmt $(PIXFMT)

 FATE_FITS_DEC_PIXFMT = gray gbrp gbrp16 gbrap16
 $(FATE_FITS_DEC_PIXFMT:%=fate-fitsdec-%): fate-fitsdec-%: tests/data/lena-%.fits
-FATE_FITS_DEC-$(call DEMDEC, FITS, FITS) += $(FATE_FITS_DEC_PIXFMT:%=fate-fitsdec-%)
+FATE_FITS_DEC-$(call ALLYES, FITS_DEMUXER FITS_DECODER PNG_DECODER) += $(FATE_FITS_DEC_PIXFMT:%=fate-fitsdec-%)

 FATE_FITS += $(FATE_FITS_DEC-yes)
 fate-fitsdec: $(FATE_FITS_DEC-yes)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170915/b96e4ab5/attachment.sig>