[FFmpeg-devel] [PATCH] pixdesc: Add API to map color property name to enum value

[Michael Niedermayer]

On Wed, Sep 20, 2017 at 02:03:02PM +0200, Nicolas George wrote:
> Le jour de la Raison, an CCXXV, Vittorio Giovara a écrit :
> > It's to be consistent with the other APIs that map a string to an enum,
> > like in spherical.c and stereo3d.c.
> 
> I think they should be fixed. Returning -1 as an error code is a path we
> definitely do not want to go again.

i agree, functions should return error codes consistently.
It adds no complexity, a named constant or -1, no extra operation,
no extra line of code

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170920/67c29a11/attachment.sig>