[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

[James Almer]

On 9/27/2017 1:37 PM, wm4 wrote:
> On Wed, 27 Sep 2017 09:17:36 -0700
> Aman Gupta <ffmpeg at tmm1.net> wrote:
> 
>> On Wed, Sep 27, 2017 at 5:51 AM, wm4 <nfxjfg at googlemail.com> wrote:
>>
>>> On Tue, 26 Sep 2017 18:08:10 -0700
>>> Aman Gupta <ffmpeg at tmm1.net> wrote:
>>>  
>>>> From: Aman Gupta <aman at tmm1.net>
>>>>
>>>> ---
>>>>  configure                    |   2 +
>>>>  libavcodec/allcodecs.c       |   1 +
>>>>  libavcodec/hevc_refs.c       |   3 +
>>>>  libavcodec/hevcdec.c         |  12 ++-
>>>>  libavcodec/vda_vt_internal.h |   1 +
>>>>  libavcodec/videotoolbox.c    | 203 ++++++++++++++++++++++++++++++  
>>> +++++++++++++  
>>>>  6 files changed, 221 insertions(+), 1 deletion(-)  
>>>
>>> PS: A final patch should make sure these symbols don't cause build
>>> failures with older SDKs:
>>>  
>>>> +        case kCMVideoCodecType_HEVC :  
>>>  
>>>> +        videotoolbox->cm_codec_type = kCMVideoCodecType_HEVC;  
>>>
>>>
>>> Maybe with a configure check.
>>>  
>>
>> This is available since macOS 10.11. How far back does ffmpeg support?
> 
> Really not sure. If VideoToolbox support is never detected before
> 10.11, then it's OK.

Videotoolbox is available since 10.8, so this definitely needs a
configure check, much like we're doing for DXVA_PicParams_HEVC in dxva2.