[FFmpeg-devel] [PATCH v2] cpu: add a function for querying maximum required data alignment

[wm4]

On Wed, 27 Sep 2017 21:37:54 -0300
James Almer <jamrial at gmail.com> wrote:

> > API users can rely on it. So you better make sure that can't break.
> > Other aspects don't really matter.  
> 
> What do you mean with this? Do i apply it or not? The function will
> return a value based on runtime cpuflags. The value is guaranteed to be
> correct, but how the user uses it is beyond our control.

If the user uses the return value of the API to align pointers, and
then passes these pointers to ffmpeg functions that process data, they
must not crash or exhibit low performance. Or in other words, the
alignment returned by the function must be high enough. At least as
long as the global CPU flags are not changed afterwards.

So if this is correct, I see no reason not to apply this patch?

I'm not sure if your question was only about this patch, or potentially
later Libav commits that need to be merged.